Upgrade the Grafana plugin's IoTDB Go client to v2.0.10 - #130
Open
PDGGK wants to merge 1 commit into
Open
Conversation
v2.0.8 accepts a columnIndex equal to the number of measurement schemas in client/tablet.go, at both of the sites that check it. v2.0.10 rejects it. v2.0.10 declares go 1.25 where v2.0.8 declared go 1.13, so the module's go directive moves with it, and the three setup-go steps in grafana-plugin.yml have to move as well for the workflow to build the backend at all. github.com/apache/thrift moves from v0.17.0 to v0.24.0 as an indirect consequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Grafana data source plugin pins
github.com/apache/iotdb-client-go/v2atv2.0.8, which carries an off-by-one bounds check thatv2.0.10fixes.In
client/tablet.go, both sites in v2.0.8 accept acolumnIndexequal to thenumber of schemas:
The corresponding two sites in v2.0.10 reject it:
v2.0.10 was published on 2026-08-21. The upgrade also picks up
rowIndexvalidation in
Tablet.SetTimestampAtand IPv6 node URLs in the cluster session.Why the CI change is in the same pull request
v2.0.10's owngo.moddeclaresgo 1.25, wherev2.0.8declaredgo 1.13.Bumping the dependency therefore forces the module's
godirective to 1.25, andgrafana-plugin.ymlpinsgo-version: "1.21"in all three jobs, two of whichrun
backend-compile.sh. Changing onlygo.modwould leave the workflow unableto build the module, so the two changes are one change.
github.com/apache/thriftmoves from v0.17.0 to v0.24.0 as an indirectconsequence of the same upgrade.
Verification
Built and tested locally on macOS with Go 1.26:
One limitation worth stating plainly: the module's test suite is a single
package that runs in 0.028s, so it does not exercise the thrift surface this
upgrade moves. The build and vet results cover compilation and the obvious
static problems; they are not evidence that the thrift 0.17 to 0.24 jump is
behaviourally safe. If the project would rather take the client bump without the
thrift jump, or wants the plugin exercised against a running Grafana first, I am
happy to do that instead.
go.sumis not in the diff becauseconnectors/grafana-plugin/.gitignore:17excludes
*.sum.Interaction with open dependabot pull requests
Three open pull requests touch the same
go.mod— #103 (otel/sdk), #72(kin-openapi) and #60 (golang.org/x/net). None of them changes the IoTDB client,
so there is no duplicated work, but whichever of us merges second will need a
rebase, and this change moves the
godirective, which is the line most likelyto conflict.